fix: race condition where webContents can be nullptr during re-focus and a multi-window close sequence #33063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and a multi-window close sequence
MarshallOfSound
added
target/17-x-y
and removed
new-pr 🌱
samuelmaddock
approved these changes
Mar 2, 2022
VerteDinde
approved these changes
Mar 14, 2022
VerteDinde
added
semver/patch
VerteDinde
force-pushed
the
MarshallOfSound-patch-1
branch
from
e77b1af
to
1e542a7
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "17-x-y", please check out #33283 |
|
I have automatically backported this PR to "18-x-y", please check out #33284 |
3 tasks
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…and a multi-window close sequence (electron#33063) * fix: race condition where webContents can be nullptr during re-focus and a multi-window close sequence * chore: update electron_inspectable_web_contents_view.mm
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…and a multi-window close sequence (electron#33063) * fix: race condition where webContents can be nullptr during re-focus and a multi-window close sequence * chore: update electron_inspectable_web_contents_view.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this fixes it but I believe this is the race condition.
Notes: Theoretical fix for a crash we're seeing when closing multiple child windows at the same time on macOS