feat: add WCO title bar style setters #33066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavin
added
semver/minor
clavin
force-pushed
the
clavin/wco-customization-setters
branch
5 times, most recently
from
2a10588
to
16283b5
Compare
clavin
force-pushed
the
clavin/wco-customization-setters
branch
2 times, most recently
from
6fbac24
to
e41a4e2
Compare
clavin
force-pushed
the
clavin/wco-customization-setters
branch
from
e41a4e2
to
71324b2
Compare
electron-cation
bot
added
api-review/approved ✅
new-pr 🌱
zcbenz
approved these changes
Mar 23, 2022
|
Release Notes Persisted
|
This was referenced Mar 25, 2022
|
I have automatically backported this PR to "17-x-y", please check out #33439 |
|
I have automatically backported this PR to "18-x-y", please check out #33440 |
3 tasks
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
* feat: add wco title bar style setters * return after throwing
3 tasks
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: add wco title bar style setters * return after throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a new API to
BrowserWindowto change the style of the window controls on a WCO-enabled window (only on Windows):BrowserWindow#setTitleBarOverlay(options: TitleBarOverlay): voidThe
optionsparameter mimics the options object in theBrowserWindowconstructor. That said, theBrowserWindowconstructor also accepts abooleanvalue, which this method does not! At least not right now, that is. Being able to toggle the titlebar overlay on and off on an already-constructed window might require a substantial refactor to recreate/adjust the entire window view hierarchy and modify the native window. Instead, I'm forgoing the toggle so I can just implement what is necessary to adjust the style of the titlebar overlay. This method is can be augmented in the future to add that functionality (that is, this API is future-compatible) if it is ever desired.Checklist
npm testpassesRelease Notes
Notes: Added
BrowserWindowmethod to change the button color, symbol color, and height of a window with WCO enabled.