Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect tray garbage collection #33076

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 24, 2022

Backport of #33040

See that PR for details.

Notes: Fixed an issue where the Tray could get garbage collected incorrectly under some circumstances.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 24, 2022
@trop trop bot requested a review from codebytere February 24, 2022 19:04
@trop trop bot mentioned this pull request Feb 24, 2022
3 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 24, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 24, 2022
@codebytere
Copy link
Member

Failure:

tag requestFullscreen from webview pressing ESC should emit the leave-html-full-screen event

is unrelated.

@codebytere codebytere merged commit 931db4a into 17-x-y Feb 25, 2022
@codebytere codebytere deleted the trop/17-x-y-bp-fix-incorrect-tray-garbage-collection-1645729471443 branch February 25, 2022 13:18
@release-clerk
Copy link

release-clerk bot commented Feb 25, 2022

Release Notes Persisted

Fixed an issue where the Tray could get garbage collected incorrectly under some circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant