chore: cherry-pick 2ed58f4 from chromium #33109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
RaisinTen
force-pushed
the
remove-incorrect-window-bound-adjustments
branch
from
491fa87
to
2e3afb7
Compare
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: electron#33049 Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
remove-incorrect-window-bound-adjustments
branch
from
2e3afb7
to
e054ed9
Compare
ckerr
approved these changes
Mar 10, 2022
|
@ckerr, it's been merged upstream, so yea, it will come out in a future roll. For context, I was the upstream issue reporter and ran it down. I also liberally applied the target labels here, so feel free to trim them back, but it feels low risk and isolated to backport. 🙂 |
|
Release Notes Persisted
|
trop bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
trop bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
|
I have automatically backported this PR to "14-x-y", please check out #33247 |
trop bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
trop bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
trop bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
|
I have automatically backported this PR to "16-x-y", please check out #33249 |
|
I have automatically backported this PR to "18-x-y", please check out #33250 |
|
I have automatically backported this PR to "17-x-y", please check out #33251 |
jkleinsc
pushed a commit
that referenced
this pull request
Mar 16, 2022
* chore: cherry-pick 2ed58f4 from chromium (#33109) Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: update patches Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
jkleinsc
pushed a commit
that referenced
this pull request
Mar 16, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
jkleinsc
pushed a commit
that referenced
this pull request
Mar 16, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
zcbenz
pushed a commit
that referenced
this pull request
Mar 21, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
zcbenz
added a commit
that referenced
this pull request
Mar 21, 2022
* chore: cherry-pick 2ed58f4 from chromium (#33109) Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: update patches Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
zcbenz
pushed a commit
that referenced
this pull request
Mar 21, 2022
* chore: cherry-pick 2ed58f4 from chromium (#33109) Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: #33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> * Trigger Build * chore: update patches Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: electron#33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658 Fixes: electron#33049 Signed-off-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Subject: [PATCH] Remove incorrect width/height adjustments
In late 2016 a change which fixed some problems around window sizing
when attaching or detaching additional displays was landed, which fixed
some genuine bugs. Unfortunately it included a subtraction of 1 from the
width and height of the Chrome window. I couldn't find any discussion of
this size adjustment and I think that it was just a misunderstanding of
how window rectangles work (inclusive versus exclusive extents).
This size adjustment causes non-maximized Chrome windows to shrink every
time a monitor is added or removed. The problematic commit was found
by the bug-filer through a bisect of more than four years of Chrome
history - I'm just landing the fix that they suggested.
Bug: 1300415
Change-Id: Ief124f584a91aa9cc3f10704b0cc1e83356dea5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3492658
Reviewed-by: Allen Bauer kylixrd@chromium.org
Commit-Queue: Bruce Dawson brucedawson@chromium.org
Cr-Commit-Position: refs/heads/main@{#975872}
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3492658
Fixes: #33049
Signed-off-by: Darshan Sen raisinten@gmail.com
Release Notes
Notes: Fixes an issue where adding/removing display changes the BrowserWindow size.