fix: disable partition alloc on mac #33114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the AppVeyor crashes are also happening on other PRs, so I don't think related to this change. |
clavin
approved these changes
Mar 1, 2022
MarshallOfSound
approved these changes
Mar 1, 2022
|
Release Notes Persisted
|
This was referenced Mar 1, 2022
|
I have automatically backported this PR to "17-x-y", please check out #33116 |
|
I have automatically backported this PR to "18-x-y", please check out #33117 |
|
Do we have additional context on why the partition allocator started crashing fork calls from uv_spawn ? |
|
What's the plan for re-enabling this? |
3 tasks
3 tasks
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
|
This can be reverted now, with #33114 integrated. |
|
See #33981 for WIP |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32718
After re-enabling partition alloc in Electron 17, we began seeing crashes when spawning child processes on Mac. This PR disables partition alloc for Mac builds to address the crash.
Checklist
npm testpassesRelease Notes
Notes: Fixed an occasional crash on Mac when spawning a child process.