fix: settings not persisting across devtools loads #33120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Mar 2, 2022
codebytere
force-pushed
the
remove-sync-settings
branch
from
54b639a
to
e243a25
Compare
deepak1556
approved these changes
Mar 7, 2022
codebytere
force-pushed
the
remove-sync-settings
branch
from
e243a25
to
06bec58
Compare
jkleinsc
approved these changes
Mar 9, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "17-x-y" cleanly; |
|
I have automatically backported this PR to "18-x-y", please check out #33206 |
deepak1556
pushed a commit
that referenced
this pull request
Mar 14, 2022
* fix: settings not persisting across devtools loads * chore: remove redundant RegisterPreference impl
|
@deepak1556 has manually backported this PR to "17-x-y", please check out #33273 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
* fix: settings not persisting across devtools loads * chore: remove redundant RegisterPreference impl
4 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: settings not persisting across devtools loads * chore: remove redundant RegisterPreference impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33102.
Closes #31864.
In #31317 we adapted to changes in this crbug, which inadvertently caused issues since we don't support synced settings in Electron. Synced settings are settings which persist across Chrome profiles, which is a concept we don't have in Electron. This removes code related to the synced settings, which caused devtools settings not to persist between loads.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Chrom DevTools settings didn't persist between loads.