Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: really strip crashpad handler binary #33175

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 7, 2022

Backport of #33126

See that PR for details.

Notes: Strip crashpad_handler binary on Linux, reducing bundle size.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 7, 2022
@trop trop bot requested a review from deermichel March 7, 2022 19:50
@trop trop bot mentioned this pull request Mar 7, 2022
2 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 7, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 7, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Mar 8, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit fb5741e into 18-x-y Mar 8, 2022
@jkleinsc jkleinsc deleted the trop/18-x-y-bp-fix-really-strip-crashpad-handler-binary-1646682629318 branch March 8, 2022 18:56
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2022

Release Notes Persisted

Strip crashpad_handler binary on Linux, reducing bundle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants