Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable SIGUSR1 when --inspect is disabled #33188

Merged
merged 1 commit into from Mar 22, 2022
Merged

fix: disable SIGUSR1 when --inspect is disabled #33188

merged 1 commit into from Mar 22, 2022

Conversation

MarshallOfSound
Copy link
Member

As in title / notes

Notes: SIGUSR1 is no longer handled when the node_cli_inspect fuse is disabled

@MarshallOfSound MarshallOfSound requested review from a team as code owners March 8, 2022 00:39
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 8, 2022
@MarshallOfSound MarshallOfSound added target/18-x-y semver/patch backwards-compatible bug fixes labels Mar 8, 2022
nornagon
nornagon reviewed Mar 8, 2022
View reviewed changes
patches/node/feat_add_knostartdebugsignalhandler_to_environment_to_prevent.patch
+ // Controls where or not the InspectorAgent for this Environment should
+ // call StartDebugSignalHandler. This control is needed by embedders who may
+ // not want to allow other processes to start the V8 inspector.
+ kNoStartDebugSignalHandler = 1 << 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be reasonable to have just one flag for "don't do the inspector stuff please", rather than N flags for each of "don't do this particular inspector thing please"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably but given these flags live in Node and we've already added a few small scoped ones I don't think Node will like the breaking change of modifying the behavior of an existing flag

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 9, 2022
@nornagon
Copy link
Member

excited for the next installment of "node added a way to enable the inspector and now we have to add a patch to disable the new way", loved the last season :)

@zcbenz zcbenz merged commit 81318f0 into main Mar 22, 2022
@zcbenz zcbenz deleted the disable-sigusr1 branch March 22, 2022 07:51
@release-clerk
Copy link

release-clerk bot commented Mar 22, 2022

Release Notes Persisted

SIGUSR1 is no longer handled when the node_cli_inspect fuse is disabled

@trop
Copy link
Contributor

trop bot commented Mar 22, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 22, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 22, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@MarshallOfSound @bavulapati
fix: disable SIGUSR1 when --inspect is disabled (electron#33188)
2df97f9
@commit-lint commit-lint bot mentioned this pull request May 10, 2022
Open
MarshallOfSound added a commit that referenced this pull request May 11, 2022
@MarshallOfSound
fix: disable SIGUSR1 when --inspect is disabled (#33188)
55aaf0d
@MarshallOfSound MarshallOfSound mentioned this pull request May 11, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 11, 2022

@MarshallOfSound has manually backported this PR to "18-x-y", please check out #34180

@MarshallOfSound MarshallOfSound mentioned this pull request May 11, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 11, 2022

@MarshallOfSound has manually backported this PR to "17-x-y", please check out #34181

MarshallOfSound added a commit that referenced this pull request May 11, 2022
@MarshallOfSound
fix: disable SIGUSR1 when --inspect is disabled (#33188)
4b1b174
@MarshallOfSound MarshallOfSound mentioned this pull request May 11, 2022
Merged
MarshallOfSound added a commit that referenced this pull request May 11, 2022
@MarshallOfSound
fix: disable SIGUSR1 when --inspect is disabled (#33188)
3b16e4e
@trop
Copy link
Contributor

trop bot commented May 11, 2022

@MarshallOfSound has manually backported this PR to "16-x-y", please check out #34182

MarshallOfSound added a commit that referenced this pull request May 11, 2022
@MarshallOfSound
fix: disable SIGUSR1 when --inspect is disabled (#34181)
fe86486 
* fix: disable SIGUSR1 when --inspect is disabled (#33188)

* Update .patches
MarshallOfSound added a commit that referenced this pull request May 11, 2022
@MarshallOfSound
fix: disable SIGUSR1 when --inspect is disabled (#34180)
b4533d1 
fix: disable SIGUSR1 when --inspect is disabled (#33188)
VerteDinde pushed a commit that referenced this pull request May 12, 2022
@MarshallOfSound
fix: disable SIGUSR1 when --inspect is disabled (#34182)
a6cee3a 
* fix: disable SIGUSR1 when --inspect is disabled (#33188)

* Update .patches

* chore: rebase patches
@Gioyik Gioyik mentioned this pull request Sep 26, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@MarshallOfSound @khalwa
fix: disable SIGUSR1 when --inspect is disabled (electron#33188)
fba3ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @nornagon @zcbenz