docs: mark skipTaskbar as unsupported on Linux #33226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
documentation 📓
semver/patch
codebytere
approved these changes
Mar 17, 2022
zcbenz
approved these changes
Mar 21, 2022
dsanders11
approved these changes
Mar 21, 2022
|
Release Notes Persisted
|
nornagon
reviewed
Mar 28, 2022
| ## Planned Breaking API Changes (19.0) | ||
|
|
||
| *None (yet)* | ||
| ### Unsupported: `skipTaskbar` on Linux |
There was a problem hiding this comment.
I missed this, but all breaking changes in this document should use one of the types described at the top of the document (API Changed / Behavior Changed / Default Changed / Deprecated / Removed).
What does Unsupported mean?
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
2 tasks
ckerr
added a commit
that referenced
this pull request
Jul 29, 2022
Marked as unsupported in e19, now removed in e20. See #33226 for more information
3 tasks
trop bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
Marked as unsupported in e19, now removed in e20. See #33226 for more information
VerteDinde
added a commit
that referenced
this pull request
Aug 1, 2022
* fix: remove skip-taskbar feature on Linux. Marked as unsupported in e19, now removed in e20. See #33226 for more information * docs: remove skipTaskbar note in browserWindow Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
|
Will this affect browserWindow.setSkipTaskbar? |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Description of Change
Closes #33124.
skipTaskbarhas no effect on Wayland. Currently Electron uses_NET_WM_STATE_SKIP_TASKBARto tell the WM to hide an app from the taskbar, and this works fine on X11 but there's no equivalent mechanism in Wayland. There are some workarounds available on different systems, e.g. GNOME and KWin, but they some unacceptable tradeoffs, e.g.Window.is_skip_taskbarrequires unsafe mode.tl;dr I don't see a way to support this feature on Linux anymore.
This PR updates the documentation to reflect that it's only supported on macOS / Windows and makes an announcement in "breaking changes" (it's broken already, but better to document it here for visibility).
Checklist
npm testpassesRelease Notes
Notes: Marked
.skipTaskbaras unsupported on Linux.