Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cppgc/node collisions in renderer process #33252

Merged
merged 2 commits into from Mar 12, 2022
Merged

fix: cppgc/node collisions in renderer process #33252

merged 2 commits into from Mar 12, 2022

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Mar 11, 2022 •
edited by codebytere

Description of Change

Closes #33164

See .patch file for description.

Checklist

Release Notes

Notes: Fixed a V8 crash that could happen randomly in non-sandboxed renderer processes.

@nornagon nornagon requested review from a team as code owners March 11, 2022 19:26
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/18-x-y labels Mar 11, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 12, 2022
@jkleinsc jkleinsc merged commit f372953 into main Mar 12, 2022
@jkleinsc jkleinsc deleted the node-cppgc branch March 12, 2022 23:28
@release-clerk
Copy link

release-clerk bot commented Mar 12, 2022

Release Notes Persisted

Fixed a V8 crash that could happen randomly in non-sandboxed renderer processes.

@trop trop bot mentioned this pull request Mar 12, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Mar 12, 2022

I have automatically backported this PR to "18-x-y", please check out #33260

@deepak1556 deepak1556 mentioned this pull request Mar 14, 2022
Closed
3 tasks
bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@nornagon @bavulapati
fix: cppgc/node collisions in renderer process (electron#33252)
79101c3 
* fix: cppgc/node collisions in renderer process

* Update be_compatible_with_cppgc.patch
@commit-lint commit-lint bot mentioned this pull request Apr 30, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
fix: cppgc/node collisions in renderer process (electron#33252)
faa498b 
* fix: cppgc/node collisions in renderer process

* Update be_compatible_with_cppgc.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Blank page on location change / reload if a filesystem asynchronous call was pending
4 participants
@nornagon @jkleinsc @codebytere @VerteDinde