fix: ensure external memory adjustments are balanced #33266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
approved these changes
Mar 13, 2022
codebytere
approved these changes
Mar 16, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "15-x-y" cleanly; |
|
I was unable to backport this PR to "16-x-y" cleanly; |
|
I have automatically backported this PR to "18-x-y", please check out #33305 |
|
I have automatically backported this PR to "17-x-y", please check out #33306 |
|
@dsanders11 has manually backported this PR to "15-x-y", please check out #33311 |
|
@dsanders11 has manually backported this PR to "16-x-y", please check out #33312 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change is modeled after how it is done for
ImageBitmapin Chromium.The current code has the potential to make unbalanced adjustments, decrementing more memory than it has incremented, which messes with the overall tracking. Currently adding a representation to an empty
nativeImagedoesn't increase the external memory count, but the destructor decrements it, leading to a net negative. If you run that in a loop, you'll eventually turn the total external allocated memory count negative.I think there are improvements to be made on the general tracking here, especially with multiple representations, but that requires more research and I wanted to start by fixing the bug here which can impact the total external allocated memory count.
cc @miniak
Checklist
npm testpassesRelease Notes
Notes: Fixed incorrect external memory allocation tracking in nativeImage module