Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when destroying node env with pending promises #33280

Merged
merged 2 commits into from Mar 16, 2022

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Mar 15, 2022

Description of Change

Fixes #33164

Checklist

Release Notes

Notes: fix crash in the render process on reload with pending node fs.promises

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 15, 2022
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/15-x-y labels Mar 15, 2022
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test - we should just need a very big file to load via fs.promises.read

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2022
@codebytere codebytere merged commit b2c5623 into main Mar 16, 2022
@codebytere codebytere deleted the robo/fix_node_env_crash branch March 16, 2022 17:54
@release-clerk
Copy link

release-clerk bot commented Mar 16, 2022

Release Notes Persisted

fix crash in the render process on reload with pending node fs.promises

@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

I have automatically backported this PR to "15-x-y", please check out #33300

@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

I have automatically backported this PR to "16-x-y", please check out #33301

@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

I have automatically backported this PR to "18-x-y", please check out #33302

@trop trop bot removed the target/18-x-y label Mar 16, 2022
@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

I have automatically backported this PR to "17-x-y", please check out #33303

@deepak1556
Copy link
Member Author

/trop run backport

@trop
Copy link
Contributor

trop bot commented Mar 18, 2022

The backport process for this PR has been manually initiated - here we go! :D

@trop
Copy link
Contributor

trop bot commented Mar 18, 2022

I have automatically backported this PR to "17-x-y", please check out #33335

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
…3280)

* fix: crash when destroying node env with pending promises

* chore: add spec
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
…3280)

* fix: crash when destroying node env with pending promises

* chore: add spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Blank page on location change / reload if a filesystem asynchronous call was pending
2 participants