fix: crash when showing item in folder on DevTools #33313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
trop
bot
added
16-x-y
backport
codebytere
changed the title
trop
bot
added
semver/patch
VerteDinde
approved these changes
Mar 17, 2022
deepak1556
approved these changes
Mar 17, 2022
zcbenz
approved these changes
Mar 21, 2022
|
Release Notes Persisted
|
vikunja-bot
pushed a commit
to go-vikunja/desktop
that referenced
this pull request
Mar 24, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [electron](https://github.com/electron/electron) | devDependencies | minor | [`17.1.2` -> `17.2.0`](https://renovatebot.com/diffs/npm/electron/17.1.2/17.2.0) | --- ### Release Notes <details> <summary>electron/electron</summary> ### [`v17.2.0`](https://github.com/electron/electron/releases/v17.2.0) [Compare Source](electron/electron@v17.1.2...v17.2.0) ### Release Notes for v17.2.0 #### Features - Added `ses.setCodeCachePath()` API for setting code cache directory. [#​33285](electron/electron#33285) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33286))</span> #### Fixes - Fire 'show' event when a BrowserWindow is shown via maximize(). [#​33213](electron/electron#33213) <span style="font-size:small;">(Also in [16](electron/electron#33212), [18](https://github.com/electron/electron/pull/33214))</span> - Fixed a network service crash that could occur when using setCertificateVerifyProc. [#​33254](electron/electron#33254) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33253))</span> - Fixed an issue where BrowserView layout bounds where limited to it's visible bounds. [#​33398](electron/electron#33398) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33399))</span> - Fixed an issue where Chrome DevTools settings didn't persist between loads. [#​33273](electron/electron#33273) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33206))</span> - Fixed an issue where clicking "Open in Containing Folder" in the Sources tab in Devtools caused a crash. [#​33196](electron/electron#33196) <span style="font-size:small;">(Also in [16](electron/electron#33313), [18](https://github.com/electron/electron/pull/33197))</span> - Fixed broken event loop in renderer process when process reuse is enabled on windows platform. [#​33362](electron/electron#33362) <span style="font-size:small;">(Also in [16](electron/electron#33363), [18](https://github.com/electron/electron/pull/33361))</span> - Fixed crash in the render process on reload with pending node fs.promises. [#​33335](electron/electron#33335) <span style="font-size:small;">(Also in [15](electron/electron#33300), [16](electron/electron#33301), [18](https://github.com/electron/electron/pull/33302))</span> - Fixed drag regions on WCO windows on Windows. [#​33201](electron/electron#33201) <span style="font-size:small;">(Also in [15](electron/electron#33199), [16](electron/electron#33200), [18](https://github.com/electron/electron/pull/33202))</span> - Fixed incorrect external memory allocation tracking in nativeImage module. [#​33306](electron/electron#33306) <span style="font-size:small;">(Also in [15](electron/electron#33311), [16](electron/electron#33312), [18](https://github.com/electron/electron/pull/33305))</span> - Theoretical fix for a crash we're seeing when closing multiple child windows at the same time on macOS. [#​33283](electron/electron#33283) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33284))</span> #### Other Changes - Fixed an issue where adding/removing display changes the BrowserWindow size. [#​33251](electron/electron#33251) <span style="font-size:small;">(Also in [14](electron/electron#33247), [15](electron/electron#33248), [16](electron/electron#33249), [18](https://github.com/electron/electron/pull/33250))</span> - Fixed an issue where moving a window created in a scaled display to a regular display would increase the window size. [#​33231](electron/electron#33231) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/83 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33024.
See that PR for details.
Notes: Fixed an issue where clicking "Open in Containing Folder" in the Sources tab in Devtools caused a crash.