Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BrowserWindow.fromWebContents should work in browser-window-created #33316

Merged
merged 1 commit into from Mar 17, 2022
Merged

fix: BrowserWindow.fromWebContents should work in browser-window-created #33316

merged 1 commit into from Mar 17, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 16, 2022

Backport of #33257

See that PR for details.

Notes: Fixed a bug where BrowserWindow.fromWebContents would return undefined during the browser-window-created event.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2022
@trop trop bot requested a review from nornagon March 16, 2022 23:23
@trop trop bot mentioned this pull request Mar 16, 2022
Merged
4 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 16, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2022
@codebytere codebytere merged commit 7283c25 into 18-x-y Mar 17, 2022
@codebytere codebytere deleted the trop/18-x-y-bp-fix-browserwindow-fromwebcontents-should-work-in-browser-window-created-1647473010173 branch March 17, 2022 08:45
@release-clerk
Copy link

release-clerk bot commented Mar 17, 2022

Release Notes Persisted

Fixed a bug where BrowserWindow.fromWebContents would return undefined during the browser-window-created event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @nornagon