Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more color formats for backgroundColor #33364

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 21, 2022

Backport of #31868

See that PR for details.

Notes: Added support for more color formats in setBackgroundColor.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2022
@trop trop bot requested a review from codebytere March 21, 2022 17:36
@trop trop bot added 18-x-y backport This is a backport PR backport/requested 🗳 semver/major incompatible API changes labels Mar 21, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2022
@jkleinsc
Copy link
Contributor

Merging as GitHub thinks build-mac workflow is still running but I verified on CircleCI that it has indeed finished and is green.

@jkleinsc jkleinsc merged commit cee4e37 into 18-x-y Mar 22, 2022
@jkleinsc jkleinsc deleted the trop/18-x-y-bp-feat-support-more-color-formats-for-backgroundcolor--1647884167369 branch March 22, 2022 00:06
@release-clerk
Copy link

release-clerk bot commented Mar 22, 2022

Release Notes Persisted

Added support for more color formats in setBackgroundColor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport/requested 🗳 backport This is a backport PR semver/major incompatible API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants