fix: non-client windows messages on legacy widget host (again) #33438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Mar 24, 2022
deepak1556
approved these changes
Mar 25, 2022
codebytere
approved these changes
Mar 25, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "15-x-y" cleanly; |
This was referenced Mar 25, 2022
|
oh no sorry i missed the new-pr time-stamp on this 😓 my deepest apologies - if there's an issue please feel free to revert! |
|
I have automatically backported this PR to "16-x-y", please check out #33444 |
|
I have automatically backported this PR to "17-x-y", please check out #33445 |
|
I have automatically backported this PR to "18-x-y", please check out #33446 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
🥲 #32871 broke the double-click-to-maximize behavior on frameless and WCO windows. As they say, third time's a charm!
To expound a bit more, this patch has been modified to follow the old code path 99% of the time, and the only time it deviates from chrome is on non-client mouse move messages. This is specifically because mouse movements are tracked on the legacy window, not the actual web content (parent) window that you see.
I manually tested all the possible window controls and title bar interactions I could, from drags and double clicks and hovers and system commands (the move and size actions in the window's system menu that you control with your keyboard). Web content below seems to be functioning right as well. Everything I can think of seems to work. Hopefully that means this patch can be upstreamed!
Checklist
npm testpassesRelease Notes
Notes: Fixed maximizing frameless windows by double-clicking on a draggable (title bar) region.