Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-client windows messages on legacy widget host (again) #33444

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 25, 2022

Backport of #33438

See that PR for details.

Notes: Fixed maximizing frameless windows by double-clicking on a draggable (title bar) region.

@trop trop bot requested review from a team as code owners March 25, 2022 10:12
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 25, 2022
@trop trop bot requested a review from clavin March 25, 2022 10:12
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 25, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 25, 2022
@zcbenz zcbenz merged commit 06a3bda into 16-x-y Mar 28, 2022
@zcbenz zcbenz deleted the trop/16-x-y-bp-fix-non-client-windows-messages-on-legacy-widget-host-again--1648203161143 branch March 28, 2022 07:34
@release-clerk
Copy link

release-clerk bot commented Mar 28, 2022

Release Notes Persisted

Fixed maximizing frameless windows by double-clicking on a draggable (title bar) region.

vikunja-bot pushed a commit to go-vikunja/desktop that referenced this pull request Mar 29, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | major | [`17.3.0` -> `18.0.0`](https://renovatebot.com/diffs/npm/electron/17.3.0/18.0.0) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v18.0.0`](https://github.com/electron/electron/releases/v18.0.0)

[Compare Source](electron/electron@v17.3.0...v18.0.0)

### Release Notes for v18.0.0

#### Features

-   Added `BrowserWindow` method to change the button color, symbol color, and height of a window with WCO enabled. [#&#8203;33440](electron/electron#33440)

#### Fixes

-   Fixed maximizing frameless windows by double-clicking on a draggable (title bar) region. [#&#8203;33446](electron/electron#33446) <span style="font-size:small;">(Also in [15](electron/electron#33449), [16](electron/electron#33444), [17](https://github.com/electron/electron/pull/33445))</span>

#### Other Changes

-   Updated Chromium to 100.0.4896.56. [#&#8203;33475](electron/electron#33475)
-   Updated node types version. [#&#8203;33477](electron/electron#33477)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/85
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants