chore: update node types version #33452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is failing lint |
clavin
force-pushed
the
clavin/update-node-types-version
branch
from
758d990
to
eec60a9
Compare
VerteDinde
approved these changes
Mar 28, 2022
|
Release Notes Persisted
|
3 tasks
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
* chore: update node types version * update express types to solve type conflict * one more yarn.lock type bump * update another types package to fix incompatible global declarations * remove incompatible type magicks * update our ambient types to match the node types * fix test type
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: update node types version * update express types to solve type conflict * one more yarn.lock type bump * update another types package to fix incompatible global declarations * remove incompatible type magicks * update our ambient types to match the node types * fix test type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update the version of
@types/nodein both the repopackage.json(mostly for the sake of tests, rather than scripts) as well as the published npmpackage.json. This doesn't match the version inDEPSbecause@types/nodedoesn't always release with Node (found this out the hard way). Fixes #33089Release Notes
Notes: Updated node types version.