fix: create userData on requestSingleInstanceLock() if needed
#33559
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deermichel
force-pushed
the
deermichel/fix-singleinstance
branch
from
9327ee6
to
94494c7
Compare
deermichel
force-pushed
the
deermichel/fix-singleinstance
branch
from
94494c7
to
701a76d
Compare
|
/ok |
deepak1556
reviewed
Mar 31, 2022
deermichel
force-pushed
the
deermichel/fix-singleinstance
branch
from
dfa9a71
to
5c80f29
Compare
deermichel
force-pushed
the
deermichel/fix-singleinstance
branch
3 times, most recently
from
8bc94e1
to
480d479
Compare
deermichel
force-pushed
the
deermichel/fix-singleinstance
branch
from
480d479
to
aa00bfd
Compare
|
@jkleinsc how to trigger linux and mac CI for PR from forks ? |
|
(@deepak1556 it's not a fork, it's just the branch name) |
deermichel
changed the title
userDataDir on requestSingleInstanceLock() if neededuserData on requestSingleInstanceLock() if needed
|
Sorry missed that, we still need to trigger the linux and mac CI for this branch, not sure why they are not run. |
trop bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
* test: use custom userData folder for requestSingleInstanceLock() * update test * prefix test folder path * fix: create userDataDir on requestSingleInstanceLock() if needed * Trigger Build
This was referenced Apr 4, 2022
|
I have automatically backported this PR to "16-x-y", please check out #33590 |
|
I have automatically backported this PR to "17-x-y", please check out #33591 |
|
I have automatically backported this PR to "18-x-y", please check out #33592 |
|
I have automatically backported this PR to "19-x-y", please check out #33593 |
zcbenz
pushed a commit
that referenced
this pull request
Apr 4, 2022
…) (#33591) * test: use custom userData folder for requestSingleInstanceLock() * update test * prefix test folder path * fix: create userDataDir on requestSingleInstanceLock() if needed * Trigger Build Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Apr 4, 2022
…) (#33592) * test: use custom userData folder for requestSingleInstanceLock() * update test * prefix test folder path * fix: create userDataDir on requestSingleInstanceLock() if needed * Trigger Build Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com>
zcbenz
pushed a commit
that referenced
this pull request
Apr 4, 2022
…) (#33593) * test: use custom userData folder for requestSingleInstanceLock() * update test * prefix test folder path * fix: create userDataDir on requestSingleInstanceLock() if needed * Trigger Build Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com>
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…tron#33559) * test: use custom userData folder for requestSingleInstanceLock() * update test * prefix test folder path * fix: create userDataDir on requestSingleInstanceLock() if needed * Trigger Build
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…tron#33559) * test: use custom userData folder for requestSingleInstanceLock() * update test * prefix test folder path * fix: create userDataDir on requestSingleInstanceLock() if needed * Trigger Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33547.
Regression introduced by #30594. The patch removed the behavior of creating the
userDatafolder if needed. Without it, the single instance lock cannot be aquired andapp.requestSingleInstanceLock()incorrectly returns false on first start of the app.This PR restores the behavior from Electron 15 and below (= before the refactor landed). Test to prevent future regressions added as well☺️ .
cc @magom001 @miniak @rzhao271
Checklist
npm testpassesRelease Notes
Notes: Fixed incorrect return value of
app.requestSingleInstanceLock()when setting non-existent user data folder.