feat: implement chrome.tabs.reload to fix PDF Viewer error #33560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
codebytere
changed the title
codebytere
force-pushed
the
fix-pdf-tab-reload-error
branch
from
76e3e53
to
2dc485f
Compare
nornagon
approved these changes
Mar 31, 2022
deepak1556
reviewed
Mar 31, 2022
There was a problem hiding this comment.
LGTM on the navigation controller calls, will delegate to @nornagon for the extension api
|
API LGTM |
|
Release Notes Persisted
|
This was referenced Apr 11, 2022
|
I have automatically backported this PR to "18-x-y", please check out #33711 |
|
I have automatically backported this PR to "19-x-y", please check out #33712 |
3 tasks
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33519.
Addresses a failure introduced by CL:3501416, whereby if a PDF failed to load:
and a user then clicked the
Reloadbutton, the following error would be seen in console:This is fixed by implementing
chrome.tabs.reload. Given it'ssemver-minoras a change, I think we should likely document it as we would if we were implementing it standalone.Note: needs tests.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the PDF Viewer would fail if a user attempted to reload.