Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create userData on requestSingleInstanceLock() if needed #33592

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 4, 2022

Backport of #33559

See that PR for details.

Notes: Fixed incorrect return value of app.requestSingleInstanceLock() when setting non-existent user data folder.

* test: use custom userData folder for requestSingleInstanceLock()

* update test

* prefix test folder path

* fix: create userDataDir on requestSingleInstanceLock() if needed

* Trigger Build
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 4, 2022
@trop trop bot requested a review from deermichel April 4, 2022 01:41
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 4, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 4, 2022
@codebytere codebytere merged commit 769088f into 18-x-y Apr 4, 2022
@codebytere codebytere deleted the trop/18-x-y-bp-fix-create-userdata-on-requestsingleinstancelock-if-needed-1649036439753 branch April 4, 2022 08:48
@release-clerk
Copy link

release-clerk bot commented Apr 4, 2022

Release Notes Persisted

Fixed incorrect return value of app.requestSingleInstanceLock() when setting non-existent user data folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants