Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "fix: some frameless windows showing a frame on Windows" #33599

Merged
merged 1 commit into from Apr 5, 2022

Conversation

MarshallOfSound
Copy link
Member

Reverts #32692

I agree with this, the original bug is solvable by following best practices. The new bugs are worse and not solvable by end users.

Notes: Fixes issues with frameless window animations and styling

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 4, 2022
@MarshallOfSound MarshallOfSound added target/15-x-y semver/patch backwards-compatible bug fixes labels Apr 4, 2022
@miniak
Copy link
Contributor

miniak commented Apr 4, 2022

@MarshallOfSound this frame thing seems to have regressed when the WCO feature was implemented on Windows.

The bug which it fixes is easily avoided by hiding the window until ready-to-show is fired, which is a best practice that's already recommended by the Electron docs to make windows load smoothly.

This makes sense to make sure the web content is loaded, but it seems a really weird workaround for making sure the window frame does render properly.

@clavin
Copy link
Member

clavin commented Apr 4, 2022

This would fix #32993 I believe

@MarshallOfSound
Copy link
Member Author

This makes sense to make sure the web content is loaded, but it seems a really weird workaround for making sure the window frame does render properly.

Weird maybe, but at the end of the day it works and you should probably be doing that anyway so I'd prefer to take that issue over the one we currently have

@mlaurencin
Copy link
Contributor

this frame thing seems to have regressed when the WCO feature was implemented on Windows.

@miniak In the original closed issue it looks like the problem was bisected to have occurred between v14.0.0-beta.3...v14.0.0-beta.5, so that would have been before the WCO. I am taking a look into the Chromium logs right now, as there were are number of rolls that may have effected things.

@MarshallOfSound MarshallOfSound merged commit a72acfc into main Apr 5, 2022
@MarshallOfSound MarshallOfSound deleted the revert-32692-fix-bw-frameless-frame-windows branch April 5, 2022 00:01
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2022

Release Notes Persisted

Fixes issues with frameless window animations and styling

@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "16-x-y", please check out #33607

@trop trop bot added the in-flight/16-x-y label Apr 5, 2022
@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "15-x-y", please check out #33608

@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "19-x-y", please check out #33609

@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "18-x-y", please check out #33610

@trop trop bot added the in-flight/19-x-y label Apr 5, 2022
@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "17-x-y", please check out #33611

@miniak
Copy link
Contributor

miniak commented Apr 6, 2022

@mlaurencin you're right, I can repro the regression occurring between those 2 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants