New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert "fix: some frameless windows showing a frame on Windows" #33599
fix: revert "fix: some frameless windows showing a frame on Windows" #33599
Conversation
This reverts commit 7c70136.
@MarshallOfSound this frame thing seems to have regressed when the WCO feature was implemented on Windows.
This makes sense to make sure the web content is loaded, but it seems a really weird workaround for making sure the window frame does render properly. |
This would fix #32993 I believe |
Weird maybe, but at the end of the day it works and you should probably be doing that anyway so I'd prefer to take that issue over the one we currently have |
@miniak In the original closed issue it looks like the problem was bisected to have occurred between v14.0.0-beta.3...v14.0.0-beta.5, so that would have been before the WCO. I am taking a look into the Chromium logs right now, as there were are number of rolls that may have effected things. |
Release Notes Persisted
|
I have automatically backported this PR to "16-x-y", please check out #33607 |
I have automatically backported this PR to "15-x-y", please check out #33608 |
I have automatically backported this PR to "19-x-y", please check out #33609 |
I have automatically backported this PR to "18-x-y", please check out #33610 |
I have automatically backported this PR to "17-x-y", please check out #33611 |
@mlaurencin you're right, I can repro the regression occurring between those 2 releases. |
…lectron#32692)" (electron#33599) This reverts commit 7c70136.
…lectron#32692)" (electron#33599) This reverts commit 7c70136.
Reverts #32692
I agree with this, the original bug is solvable by following best practices. The new bugs are worse and not solvable by end users.
Notes: Fixes issues with frameless window animations and styling