Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: some frameless windows showing a frame on Windows #33608

Merged
merged 1 commit into from May 19, 2022
Merged

revert: some frameless windows showing a frame on Windows #33608

merged 1 commit into from May 19, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 5, 2022

Backport of #33599

See that PR for details.

Notes: Fixes issues with frameless window animations and styling

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2022
@trop trop bot requested a review from MarshallOfSound April 5, 2022 00:02
@trop trop bot mentioned this pull request Apr 5, 2022
Merged
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 5, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2022
@mikeseese mikeseese mentioned this pull request Apr 12, 2022
Closed
3 tasks
jkleinsc
jkleinsc previously requested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures need to be addressed before this is merged.

@miniak miniak force-pushed the trop/15-x-y-bp-fix-revert-fix-some-frameless-windows-showing-a-frame-on-windows--1649116944105 branch from 7c0c786 to 617d1cc Compare May 11, 2022 22:59
@miniak miniak requested a review from jkleinsc May 12, 2022 02:08
@miniak
Copy link
Contributor

miniak commented May 12, 2022

@jkleinsc I've rebased the branch and it's looking better now

@codebytere codebytere changed the title fix: revert "fix: some frameless windows showing a frame on Windows" revert: some frameless windows showing a frame on Windows May 12, 2022
@miniak
Copy link
Contributor

miniak commented May 18, 2022 •
edited

ping @jkleinsc @codebytere, we should merge this before 15-x-y is EOLed next week

@codebytere codebytere dismissed jkleinsc’s stale review May 19, 2022 08:14

Test failures have been addressed!

@codebytere
Copy link
Member

WOA failure:

chromium features window.open disables JavaScript when it is disabled on the parent window

Is known and unrelated.

@codebytere codebytere merged commit 37558a6 into 15-x-y May 19, 2022
@codebytere codebytere deleted the trop/15-x-y-bp-fix-revert-fix-some-frameless-windows-showing-a-frame-on-windows--1649116944105 branch May 19, 2022 08:15
@release-clerk
Copy link

release-clerk bot commented May 19, 2022

Release Notes Persisted

Fixes issues with frameless window animations and styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @codebytere @jkleinsc @zcbenz @MarshallOfSound