Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert "fix: some frameless windows showing a frame on Windows" #33611

Merged
merged 1 commit into from Apr 5, 2022
Merged

fix: revert "fix: some frameless windows showing a frame on Windows" #33611

merged 1 commit into from Apr 5, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 5, 2022

Backport of #33599

See that PR for details.

Notes: Fixes issues with frameless window animations and styling

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2022
@trop trop bot requested a review from MarshallOfSound April 5, 2022 00:02
@trop trop bot mentioned this pull request Apr 5, 2022
Merged
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 5, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2022
VerteDinde
VerteDinde approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Mac test failed, known flake and unrelated

@VerteDinde VerteDinde merged commit 3a61e4c into 17-x-y Apr 5, 2022
@VerteDinde VerteDinde deleted the trop/17-x-y-bp-fix-revert-fix-some-frameless-windows-showing-a-frame-on-windows--1649116948370 branch April 5, 2022 18:30
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2022

Release Notes Persisted

Fixes issues with frameless window animations and styling

@mikeseese mikeseese mentioned this pull request Apr 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @VerteDinde @MarshallOfSound