Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing translation string for ax tree #33614

Merged
merged 1 commit into from Apr 5, 2022
Merged

fix: add missing translation string for ax tree #33614

merged 1 commit into from Apr 5, 2022

Conversation

MarshallOfSound
Copy link
Member

Fixes https://sentry.io/share/issue/be7de46ea41d4628ac692dadc5a8248d/

Notes: Fixed potential crash while generating accessibility trees for certain images

@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/18-x-y labels Apr 5, 2022
@VerteDinde
Copy link
Member

Opting to merge this PR in now in the interest of getting a backport queued up and green for 18-x-y and 19-x-y before tomorrow morning - build-linux is failing one test, which is a known flake.

@VerteDinde VerteDinde merged commit fcbdaab into main Apr 5, 2022
@VerteDinde VerteDinde deleted the add-missing-string branch April 5, 2022 03:22
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2022

Release Notes Persisted

Fixed potential crash while generating accessibility trees for certain images

@trop trop bot mentioned this pull request Apr 5, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "18-x-y", please check out #33616

@trop trop bot mentioned this pull request Apr 5, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 5, 2022

I have automatically backported this PR to "19-x-y", please check out #33617

@andersk andersk mentioned this pull request Apr 10, 2022
Closed
3 tasks
@andersk
Copy link
Contributor

andersk commented Apr 10, 2022 •
edited

This fix didn’t seem to work; 18.0.3 and 20.0.0-nightly.20220411 are still crashing on this resource.

Edit: fixed in 18.1.0.

@MRayermannMSFT
Copy link
Contributor

@MarshallOfSound @VerteDinde

@MRayermannMSFT MRayermannMSFT mentioned this pull request Apr 21, 2022
Closed
3 tasks
@MRayermannMSFT
Copy link
Contributor

Ok, I'm just a slow-poke here. I think I understand now. The fix did not take, and another fix was made in 18.1.0. I'm all good.

@MarshallOfSound
Copy link
Member Author

@MRayermannMSFT Please don't randomly tag maintainers, I have mention notifications enabled for important issues, not a comment consistent of just two @ mentions.

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@MarshallOfSound @bavulapati
fix: add missing translation string for ax tree (electron#33614)
2c1d7ac
@commit-lint commit-lint bot mentioned this pull request Jun 6, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@MarshallOfSound @khalwa
fix: add missing translation string for ax tree (electron#33614)
0f14645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MarshallOfSound @VerteDinde @andersk @MRayermannMSFT @miniak