feat: allow null when subscribing notification
#33641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
codebytere
changed the title
null when subscribing notification
codebytere
force-pushed
the
allow-null-subscribe
branch
from
1f44caf
to
65b4d80
Compare
nornagon
reviewed
Apr 6, 2022
This comment was marked as spam.
This comment was marked as spam.
nornagon
approved these changes
Apr 7, 2022
miniak
approved these changes
Apr 8, 2022
|
API LGTM |
1 similar comment
|
API LGTM |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "17-x-y" cleanly; |
This was referenced Apr 13, 2022
|
I have automatically backported this PR to "19-x-y", please check out #33770 |
|
I have automatically backported this PR to "18-x-y", please check out #33771 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
* feat: allow null when subscribing notification * docs: document null event
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: allow null when subscribing notification * docs: document null event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33632.
Allows for
systemPreferences.subscribe{Local|Workspace}Notificationmethods to takenullfor their event parameters.Per documentation:
cc @knev
Checklist
npm testpassesRelease Notes
Notes: Enabled
systemPreferences.subscribe{Local|Workspace}Notificationto take anullvalue for theeventparameter.