build: temporarily disable 32-bit Windows symbol generation #33653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
added
fast-track 🚅
VerteDinde
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Ported over additional changes based on this branch; approving now contingent on CI finishing green.
VerteDinde
force-pushed
the
disable-ia32-win-symbols
branch
from
e46291c
to
584b44a
Compare
|
WOA test failures unrelated (all appearing on app.requestSingletonInstanceLock) |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "19-x-y" cleanly; |
VerteDinde
added a commit
that referenced
this pull request
Apr 9, 2022
* build: temporarily disable 32-bit Windows symbol generation * fix: modify upload.py * chore: fix comment Co-authored-by: VerteDinde <vertedinde@electronjs.org>
|
@VerteDinde has manually backported this PR to "19-x-y", please check out #33689 |
5 tasks
VerteDinde
added a commit
that referenced
this pull request
Apr 11, 2022
…33689) * build: temporarily disable 32-bit Windows symbol generation (#33653) * build: temporarily disable 32-bit Windows symbol generation * fix: modify upload.py * chore: fix comment Co-authored-by: VerteDinde <vertedinde@electronjs.org> * chore: upload correct assets Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…#33653) * build: temporarily disable 32-bit Windows symbol generation * fix: modify upload.py * chore: fix comment Co-authored-by: VerteDinde <vertedinde@electronjs.org>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…#33653) * build: temporarily disable 32-bit Windows symbol generation * fix: modify upload.py * chore: fix comment Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist
Release Notes
Notes: Temporarily disabled symbol generation on 32-bit Windows due to issues with symbol generation on that platform.