New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backport unseasoned pdf support to 18.x #33664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
added
backport-check-skip
Skip trop's backport validity checking
semver/patch
backwards-compatible bug fixes
labels
Apr 7, 2022
Can you also include #33513 as part of this PR, thanks! |
VerteDinde
approved these changes
Apr 8, 2022
@deepak1556 done |
codebytere
approved these changes
Apr 11, 2022
3 tasks
deepak1556
approved these changes
Apr 12, 2022
Release Notes Persisted
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
18-x-y
backport-check-skip
Skip trop's backport validity checking
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This backports support for the unseasoned (pepper-free) PDF viewer from 19.x+,
and fixes PDF rendering in 18.x.
Closes #33519.
Checklist
Release Notes
Notes: Fixed the built-in PDF renderer.