Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Mac] Disable MallocNanoZone #33704

Merged
merged 1 commit into from Apr 28, 2022

Conversation

pr0t4zy
Copy link
Contributor

@pr0t4zy pr0t4zy commented Apr 11, 2022

Upstream change: https://chromium-review.googlesource.com/c/chromium/src/+/1137131/

Not disabling nano malloc zone not only causes the issues listed in https://bugs.chromium.org/p/chromium/issues/detail?id=861939, but also breaks Partition Alloc.

This change should fix #32718 making it possible to get rid of #33114.

Release Notes

Notes: [Mac] Fixed Partition Alloc related crash in pre-BigSur (macos <= 10.15).

@welcome
Copy link

welcome bot commented Apr 11, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 11, 2022
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels Apr 11, 2022
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work! Thanks for this.

@pr0t4zy
Copy link
Contributor Author

pr0t4zy commented Apr 11, 2022

The (random?) failures look like a missing dependency: common target in storage/common/BUILD.gn should depend on //content/public/common (as per comment in https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/BUILD.gn).

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 12, 2022
@pr0t4zy
Copy link
Contributor Author

pr0t4zy commented Apr 12, 2022

There was a build failure, unrelated to my change. Can the failed checks be re-run? Thank you!

Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this!

@codebytere codebytere mentioned this pull request Apr 13, 2022
3 tasks
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 192a7fa into electron:main Apr 28, 2022
@welcome
Copy link

welcome bot commented Apr 28, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Apr 28, 2022

Release Notes Persisted

[Mac] Fixed Partition Alloc related crash in pre-BigSur (macos <= 10.15).

@trop
Copy link
Contributor

trop bot commented Apr 28, 2022

I have automatically backported this PR to "18-x-y", please check out #33965

@trop
Copy link
Contributor

trop bot commented Apr 28, 2022

I have automatically backported this PR to "19-x-y", please check out #33966

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@miniak
Copy link
Contributor

miniak commented Jun 25, 2022

/trop run backport-to 17-x-y

@trop
Copy link
Contributor

trop bot commented Jun 25, 2022

The backport process for this PR has been manually initiated - sending your PR to 17-x-y!

@trop
Copy link
Contributor

trop bot commented Jun 25, 2022

I have automatically backported this PR to "17-x-y", please check out #34734

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Segmentation fault in uv_spawn with Electron 17.0.0
8 participants