New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Mac] Disable MallocNanoZone #33704
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
c45e7a8
to
6474a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work! Thanks for this.
The (random?) failures look like a missing dependency: |
03a2bc2
to
6474a8d
Compare
There was a build failure, unrelated to my change. Can the failed checks be re-run? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing this!
Merging as CI failure unrelated to PR change. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
I have automatically backported this PR to "18-x-y", please check out #33965 |
I have automatically backported this PR to "19-x-y", please check out #33966 |
/trop run backport-to 17-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "17-x-y", please check out #34734 |
Upstream change: https://chromium-review.googlesource.com/c/chromium/src/+/1137131/
Not disabling nano malloc zone not only causes the issues listed in https://bugs.chromium.org/p/chromium/issues/detail?id=861939, but also breaks Partition Alloc.
This change should fix #32718 making it possible to get rid of #33114.
npm test
passesRelease Notes
Notes: [Mac] Fixed Partition Alloc related crash in pre-BigSur (macos <= 10.15).