Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report more detailed errors in shell.openExternal() on Windows #33705

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 11, 2022

Backport of #33620

See that PR for details.

Notes: shell.openExternal() now reports more detailed errors on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 11, 2022
@trop trop bot requested a review from miniak April 11, 2022 15:54
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 11, 2022
@deepak1556 deepak1556 merged commit 0f07318 into 18-x-y Apr 12, 2022
@deepak1556 deepak1556 deleted the trop/18-x-y-bp-fix-report-more-detailed-errors-in-shell-openexternal-on-windows-1649692466009 branch April 12, 2022 05:18
@release-clerk
Copy link

release-clerk bot commented Apr 12, 2022

Release Notes Persisted

shell.openExternal() now reports more detailed errors on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants