fix: #ARGB to #RGBA conversion

[codebytere]

Description of Change

Fixes an issue where #ARGB ->#RGBA and #AARRGGBB ->#RRGGBBAA were converted improperly when setting background color.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where #ARGB ->#RGBA and #AARRGGBB ->#RRGGBBAA were converted improperly when setting background color.

[nornagon]

whoops!

[RaisinTen]

Is there a test case where the previous version would parse out a faulty color string? I was wondering if this could also be covered with a test maybe here -

electron/spec-main/api-browser-window-spec.ts

Line 1079 in c9fd255

it('returns correct color with multiple passed formats', () => {

?

[codebytere]

@RaisinTen no - the issue is we don't get the alpha value back out so we can't properly compare it. That's something we could eventually consider changing, but probably out of scope of this PR. I've applied the other fix though!

[release-clerk]

Release Notes Persisted

Fixed an issue where #ARGB ->#RGBA and #AARRGGBB ->#RRGGBBAA were converted improperly when setting background color.

[trop]

I have automatically backported this PR to "19-x-y", please check out #33755