Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement chrome.tabs.reload to fix PDF Viewer error #33711

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 11, 2022

Backport of #33560

See that PR for details.

Notes: Fixed an issue where the PDF Viewer would fail if a user attempted to reload.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 11, 2022
@trop trop bot requested a review from codebytere April 11, 2022 20:51
@trop trop bot added 18-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Apr 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 11, 2022
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases

@VerteDinde VerteDinde merged commit b6d6f86 into 18-x-y Apr 27, 2022
@VerteDinde VerteDinde deleted the trop/18-x-y-bp-feat-implement-chrome-tabs-reload-to-fix-pdf-viewer-error-1649710306001 branch April 27, 2022 19:18
@release-clerk
Copy link

release-clerk bot commented Apr 27, 2022

Release Notes Persisted

Fixed an issue where the PDF Viewer would fail if a user attempted to reload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants