Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow null when subscribing notification #33770

Merged
merged 2 commits into from Apr 28, 2022
Merged

feat: allow null when subscribing notification #33770

merged 2 commits into from Apr 28, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 13, 2022

Backport of #33641

See that PR for details.

Notes: Enabled systemPreferences.subscribe{Local|Workspace}Notification to take a null value for the event parameter.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2022
@trop trop bot requested a review from codebytere April 13, 2022 20:03
@trop trop bot mentioned this pull request Apr 13, 2022
Merged
5 tasks
@trop trop bot added 19-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Apr 13, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2022
VerteDinde
VerteDinde approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases

@zcbenz zcbenz force-pushed the trop/19-x-y-bp-feat-allow-null-when-subscribing-notification-1649880185138 branch from 8129d7c to 99bd810 Compare April 28, 2022 02:53
@jkleinsc jkleinsc merged commit dce5680 into 19-x-y Apr 28, 2022
@jkleinsc jkleinsc deleted the trop/19-x-y-bp-feat-allow-null-when-subscribing-notification-1649880185138 branch April 28, 2022 16:20
@release-clerk
Copy link

release-clerk bot commented Apr 28, 2022

Release Notes Persisted

Enabled systemPreferences.subscribe{Local|Workspace}Notification to take a null value for the event parameter.

@ErikSin ErikSin mentioned this pull request Jan 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
19-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkleinsc @zcbenz @VerteDinde @codebytere