Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix FirstPartySetsHandler initialization #33971

Merged
merged 1 commit into from Apr 29, 2022
Merged

Conversation

VerteDinde
Copy link
Member

Description of Change

Initialization for FirstPartySets was removed in a recent Chromium roll.

This PR re-adds the FPS initialization, and updates it based on the Chromium updates from that CL.

Checklist

Release Notes

Notes: Fixed the initialization of First Party Sets

@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes target/19-x-y labels Apr 29, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2022
@trop
Copy link
Contributor

trop bot commented Apr 29, 2022

@VerteDinde has manually backported this PR to "19-x-y", please check out #33972

@VerteDinde VerteDinde added the backport-check-skip Skip trop's backport validity checking label Apr 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2022
@VerteDinde VerteDinde removed the backport-check-skip Skip trop's backport validity checking label Apr 29, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2022
@VerteDinde VerteDinde merged commit 015185a into main Apr 29, 2022
@VerteDinde VerteDinde deleted the fix-fps-handler branch April 29, 2022 05:17
@release-clerk
Copy link

release-clerk bot commented Apr 29, 2022

Release Notes Persisted

Fixed the initialization of First Party Sets

@deepak1556
Copy link
Member

@VerteDinde the initialization is now done by the content layer https://chromium-review.googlesource.com/c/chromium/src/+/3448551, I actually removed based on it. Is this still needed ?

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@VerteDinde
Copy link
Member Author

@deepak1556 Thanks for catching this! I checked to see if we can just remove the Electron-side code entirely, and it looks like it's unfortunately still needed. From what I can tell, we always have to initialize it on Electron's end with an empty file, or the feature itself is never initialized and fails when you pass the actual sets in, either via a file or via the command line.

With this PR, though, I re-added this initialization to the wrong location. Fixed here 🙇‍♀️ : https://github.com/electron/electron/tree/move-fpsh-to-browser-process

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants