New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix FirstPartySetsHandler initialization #33971
Conversation
@VerteDinde has manually backported this PR to "19-x-y", please check out #33972 |
Release Notes Persisted
|
@VerteDinde the initialization is now done by the content layer https://chromium-review.googlesource.com/c/chromium/src/+/3448551, I actually removed based on it. Is this still needed ? |
@deepak1556 Thanks for catching this! I checked to see if we can just remove the Electron-side code entirely, and it looks like it's unfortunately still needed. From what I can tell, we always have to initialize it on Electron's end with an empty file, or the feature itself is never initialized and fails when you pass the actual sets in, either via a file or via the command line. With this PR, though, I re-added this initialization to the wrong location. Fixed here 🙇♀️ : https://github.com/electron/electron/tree/move-fpsh-to-browser-process |
Description of Change
Initialization for FirstPartySets was removed in a recent Chromium roll.
This PR re-adds the FPS initialization, and updates it based on the Chromium updates from that CL.
Checklist
npm test
passesRelease Notes
Notes: Fixed the initialization of First Party Sets