Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move FirstPartySets initialization into the browser process #33998

Merged
merged 1 commit into from May 2, 2022

Conversation

VerteDinde
Copy link
Member

Description of Change

In this CL, First Party Sets initialization was moved to the content layer: https://chromium-review.googlesource.com/c/chromium/src/+/3448551 . We still need to initialize an empty sets file within Electron's equivalent PreMainMessageLoopRun method. However, our First Party Set initialization is currently in the wrong place.

This PR moves Electron's First Party Sets initialization to the PreMainMessageLoopRun method.

Checklist

Release Notes

Notes: Fixed the initialization of first party sets in the browser process.

@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes target/19-x-y labels May 2, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 2, 2022
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarshallOfSound
Copy link
Member

@deepak1556 I don't believe so, currently the only way we have to set FPS is via command line flags. If we use a way to set FPS via other //content APIs we'll probably have to set up persistence 👍

@VerteDinde VerteDinde merged commit 14f07d7 into main May 2, 2022
@VerteDinde VerteDinde deleted the move-fpsh-to-browser-process branch May 2, 2022 15:20
@release-clerk
Copy link

release-clerk bot commented May 2, 2022

Release Notes Persisted

Fixed the initialization of first party sets in the browser process.

@trop
Copy link
Contributor

trop bot commented May 2, 2022

I have automatically backported this PR to "19-x-y", please check out #34011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants