chore: cherry-pick cf64617c1cc5 from chromium #34052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
added
18-x-y
backport-check-skip
electron-cation
bot
added
new-pr 🌱
codebytere
approved these changes
May 4, 2022
zcbenz
approved these changes
May 5, 2022
|
Release Notes Persisted
|
vikunja-bot
pushed a commit
to go-vikunja/desktop
that referenced
this pull request
May 11, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [electron](https://github.com/electron/electron) | devDependencies | patch | [`18.2.0` -> `18.2.2`](https://renovatebot.com/diffs/npm/electron/18.2.0/18.2.2) | --- ### Release Notes <details> <summary>electron/electron</summary> ### [`v18.2.2`](https://github.com/electron/electron/releases/v18.2.2) [Compare Source](electron/electron@v18.2.0...v18.2.2) ### Release Notes for v18.2.2 #### Fixes - Fixed a crash on Windows when opening apps in multiple, separate user sessions. [#​34161](electron/electron#34161) <span style="font-size:small;">(Also in [19](https://github.com/electron/electron/pull/34160))</span> - Fixed an OSR crash happening when input select items were rendered. [#​34092](electron/electron#34092) <span style="font-size:small;">(Also in [17](electron/electron#34091), [19](https://github.com/electron/electron/pull/34093))</span> - Fixed an issue where calling `SetLoginItemSettings()` could potentially cause network volumes to be incorrectly mounted. [#​34106](electron/electron#34106) <span style="font-size:small;">(Also in [17](electron/electron#34107), [19](https://github.com/electron/electron/pull/34108))</span> - Fixed crash on startup due to missing gtk symbol on older distros. [#​34150](electron/electron#34150) <span style="font-size:small;">(Also in [19](https://github.com/electron/electron/pull/34151))</span> #### Other Changes - Backported fix for CVE-2022-1485. [#​34052](electron/electron#34052) - Backported fix for CVE-2022-1497. [#​34072](electron/electron#34072) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/93 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSA: Pass File ownership to worker for async FSARFD file operations
We cannot access the backing file as a member of the
FileSystemAccessRegularFileDelegate since WrapCrossThreadPersistent
does NOT cancel the task posted to the worker pool if delegate is
destroyed. Passing ownership to the worker task ensures the file must
be alive when used. After the operation, ownership of the file is
passed back to the delegate.
This pattern was already used for the SetLength operation on old Macs.
Bug: 1299743
Change-Id: Ie00c09e8f77dc353f280af726a68ed6c572b750b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498864
Reviewed-by: Marijn Kruisselbrink mek@chromium.org
Commit-Queue: Austin Sullivan asully@chromium.org
Cr-Commit-Position: refs/heads/main@{#980167}
Notes: Backported fix for CVE-2022-1485.