Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent SetLoginItemSettings() from mounting volumes #34068

Merged
merged 1 commit into from May 6, 2022
Merged

fix: prevent SetLoginItemSettings() from mounting volumes #34068

merged 1 commit into from May 6, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Update SetLoginItemSettings to include CL:964074. From the CL:

If a user has a network volumes listed in login items, calling
LSSharedFileListItemCopyResolvedURL() will cause an attempt to mount
those volumes. This is confusing behavior because it is not relevant to
the user's action (which is likely installing PWA or Chrome extension
with a background page). Also the name "GetLoginFileList" doesn't
indicate there is any such side-effect expected. Using kLSSharedFileListDoNotMountVolumes flag will prevent this
behavior.

Checklist

Release Notes

Notes: Fixed an issue where calling SetLoginItemSettings() could potentially cause network volumes to be incorrectly mounted.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/17-x-y labels May 4, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 4, 2022
@codebytere codebytere force-pushed the update-RemoveFromLoginItems branch from a67b71e to a965c4f Compare May 4, 2022 08:47
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2022
@jkleinsc jkleinsc merged commit a401360 into main May 6, 2022
@jkleinsc jkleinsc deleted the update-RemoveFromLoginItems branch May 6, 2022 00:46
@release-clerk
Copy link

release-clerk bot commented May 6, 2022

Release Notes Persisted

Fixed an issue where calling SetLoginItemSettings() could potentially cause network volumes to be incorrectly mounted.

This was referenced May 6, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 6, 2022

I have automatically backported this PR to "18-x-y", please check out #34106

@trop trop bot added the in-flight/18-x-y label May 6, 2022
@trop
Copy link
Contributor

trop bot commented May 6, 2022

I have automatically backported this PR to "17-x-y", please check out #34107

@trop
Copy link
Contributor

trop bot commented May 6, 2022

I have automatically backported this PR to "19-x-y", please check out #34108

@commit-lint commit-lint bot mentioned this pull request Jul 11, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
refactor: prevent RemoveFromLoginItems() from mounting volumes from l…
8bfb282 
…ogin items (electron#34068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @nornagon @jkleinsc