fix: building node modules with Visual Studio 2017

[miniak]

Description of Change

Build error occurs when [[deprecated]] is used in this context in Visual Studio 2017:

  template <class S>
  V8_DEPRECATE_SOON("See class comment.")
  TracedGlobal(Isolate* isolate, Local<S> that) : BasicTracedReference<T>() {
    this->val_ =
        this->New(isolate, that.val_, &this->val_,
                  internal::GlobalHandleDestructionMode::kWithDestructor,
                  internal::GlobalHandleStoreMode::kInitializingStore);
    static_assert(std::is_base_of<T, S>::value, "type check");
  }

https://developercommunity2.visualstudio.com/t/Adding-deprecated-to-a-templated-con/1232182
https://stackoverflow.com/questions/38499462/how-to-tell-clang-to-stop-pretending-to-be-other-compilers

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed building node modules with Visual Studio 2017

[trop]

@miniak has manually backported this PR to "18-x-y", please check out #34110

[nornagon]

can you upstream this whole patch please?

[nornagon]

also, building node modules with MSVC sounds like a recipe for disaster unless you're using N-API 😬

[miniak]

can you upstream this whole patch please?
@nornagon I can do that, but I don't think we should block this PR on that considering that we already have this patch and I am just fixing it.

[jkleinsc]

Patch fails to build

[miniak]

@jkleinsc fixed

stale

[release-clerk]

Release Notes Persisted

Fixed building node modules with Visual Studio 2017

[trop]

I have automatically backported this PR to "19-x-y", please check out #34164