Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building node modules with Visual Studio 2017 #34110

Merged
merged 1 commit into from May 11, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 6, 2022

Backport of #34109

Notes: Fixed building node modules with Visual Studio 2017

@miniak miniak requested review from a team as code owners May 6, 2022 04:01
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 6, 2022
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 6, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 6, 2022
codebytere
codebytere previously approved these changes May 9, 2022
@codebytere codebytere dismissed their stale review May 9, 2022 11:09

Dismissing since i missed the comment on #34109

@miniak miniak force-pushed the miniak/deprecated-attribute-18-x-y branch from 9285f65 to 3ad018b Compare May 9, 2022 21:24
@miniak miniak added backport This is a backport PR and removed backport This is a backport PR labels May 10, 2022
@deepak1556 deepak1556 merged commit 601ca74 into 18-x-y May 11, 2022
@deepak1556 deepak1556 deleted the miniak/deprecated-attribute-18-x-y branch May 11, 2022 08:02
@release-clerk
Copy link

release-clerk bot commented May 11, 2022

Release Notes Persisted

Fixed building node modules with Visual Studio 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants