Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load FirstPartySets without Electron initialization #34138

Merged
merged 1 commit into from May 9, 2022

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented May 9, 2022

Description of Change

Currently, First Party Sets in Electron loads correctly on Mac, but fails to load (inconsistently) on Windows. Chromium has made a series of upstream improvements to First Party Sets in the 103 branch, which have not yet been backported to 102/Electron 19.

This PR backports the change that allows First Party Sets to be loaded in the content layer, without requiring Electron to explicitly call SetPublicFirstPartySets() at some point on our side.

Note: This change will also land in main once the current Chromium backport roll is landed.

CL 3623985: Replace ad-hoc SetPublicFirstPartySets calls with method in ContentBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/3623985

Checklist

Release Notes

Notes: Fixed the initialization of First Party Sets on Windows, where First Party Sets would sometimes fail to load.

@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 19-x-y labels May 9, 2022
@VerteDinde VerteDinde requested review from a team as code owners May 9, 2022 02:51
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codebytere codebytere merged commit d5dadd0 into 19-x-y May 9, 2022
@codebytere codebytere deleted the fps-load-content-layer-19-x-y branch May 9, 2022 08:44
@release-clerk
Copy link

release-clerk bot commented May 9, 2022

Release Notes Persisted

Fixed the initialization of First Party Sets on Windows, where First Party Sets would sometimes fail to load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants