fix: load FirstPartySets without Electron initialization #34138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently, First Party Sets in Electron loads correctly on Mac, but fails to load (inconsistently) on Windows. Chromium has made a series of upstream improvements to First Party Sets in the 103 branch, which have not yet been backported to 102/Electron 19.
This PR backports the change that allows First Party Sets to be loaded in the content layer, without requiring Electron to explicitly call
SetPublicFirstPartySets()
at some point on our side.Note: This change will also land in main once the current Chromium backport roll is landed.
CL 3623985: Replace ad-hoc SetPublicFirstPartySets calls with method in ContentBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/3623985
Checklist
npm test
passesRelease Notes
Notes: Fixed the initialization of First Party Sets on Windows, where First Party Sets would sometimes fail to load.