New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WCO crash on bad titlebarStyle
#34140
Conversation
titlebarStyle
@jkleinsc it looks like the WOA failure is real - would you be able to potentially help verify on your local machine? |
Looks like both (x64 + WOA) windows failures are legit @codebytere |
I see two options:
Thoughts? @jkleinsc @MarshallOfSound |
@codebytere I'd pick option 2. |
842ffdd
to
5b7719d
Compare
@jkleinsc done! |
5b7719d
to
0b94727
Compare
0b94727
to
3755fc8
Compare
Release Notes Persisted
|
I was unable to backport this PR to "19-x-y" cleanly; |
@codebytere has manually backported this PR to "19-x-y", please check out #34302 |
/trop run backport-to 18-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I was unable to backport this PR to "18-x-y" cleanly; |
fix: WCO crash on bad titlebarStyle
Description of Change
Closes #34137.
Fixes an issue where calling
setTitlebarOverlay
with an initially invalidtitleBarStyle
on Windows would result in a crash. Ideally, we'd throw in the constructor, but that causes a whole host of issues, so we instead no-op if we attempt to callsetTitleBarStyle
and the overlay was never correctly initialized.Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where calling
setTitlebarOverlay
with an initially invalidtitleBarStyle
on Windows would result in a crash.