Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on startup due to missing gtk symbol on older distros #34141

Merged
merged 1 commit into from May 9, 2022
Merged

fix: crash on startup due to missing gtk symbol on older distros #34141

merged 1 commit into from May 9, 2022

Conversation

deepak1556
Copy link
Member

Description of Change

Fixes #34118

Check for availability of gtk_native_dialog_get_type which is only available with >= 3.20 symbol used by the gtk_native_dialog_* code path

Release Notes

Notes: fix crash on startup due to missing gtk symbol on older distros

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 9, 2022
@deepak1556 deepak1556 added target/18-x-y semver/patch backwards-compatible bug fixes labels May 9, 2022
@MarshallOfSound MarshallOfSound merged commit 00368ac into main May 9, 2022
@MarshallOfSound MarshallOfSound deleted the robo/fix_gtk_startup_crash branch May 9, 2022 20:37
@release-clerk
Copy link

release-clerk bot commented May 9, 2022

Release Notes Persisted

fix crash on startup due to missing gtk symbol on older distros

This was referenced May 9, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 9, 2022

I have automatically backported this PR to "18-x-y", please check out #34150

@trop
Copy link
Contributor

trop bot commented May 9, 2022

I have automatically backported this PR to "19-x-y", please check out #34151

@miniak
Copy link
Contributor

miniak commented Jun 25, 2022

/trop run backport-to 17-x-y

@trop
Copy link
Contributor

trop bot commented Jun 25, 2022

The backport process for this PR has been manually initiated - sending your PR to 17-x-y!

@trop
Copy link
Contributor

trop bot commented Jun 25, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2022
@miniak miniak mentioned this pull request Jun 28, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jun 28, 2022

@miniak has manually backported this PR to "17-x-y", please check out #34774

@commit-lint commit-lint bot mentioned this pull request Jul 13, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@deepak1556 @khalwa
chore: stub gtk_native_dialog_get_type (electron#34141)
b8e5852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

@deermichel deermichel deermichel approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug, linux] crash on start undefined symbol: gtk_native_dialog_get_type
6 participants
@deepak1556 @miniak @ckerr @codebytere @deermichel @MarshallOfSound