fix: call loadUrl when opening new windows from links #34159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
May 10, 2022
codebytere
force-pushed
the
fix-new-window-open
branch
from
ddbdac0
to
eccb487
Compare
samuelmaddock
approved these changes
May 10, 2022
MarshallOfSound
approved these changes
May 11, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "18-x-y" cleanly; |
|
I have automatically backported this PR to "19-x-y", please check out #34189 |
|
Is this going to be backported to Electron 18? |
|
@codebytere has manually backported this PR to "18-x-y", please check out #34910 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: call loadUrl when opening new windows from links * spec: add regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34152.
Fixes an issue where windows opened from new links wouldn't properly load URLs. This happened as a result of cleanup in d44a187 - a section of code was removed which loaded the url for non-guest windows in
openGuestWindow. It's actually the case that this code is necessary when we're opening new windows from links as well. When we open a new window from a link viaShift+LeftClick, this routes throughOpenUrlFromTab, at which point the browser process is responsible for initiating navigation in the new window. This PR restores that code and updates the comment accordingly.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where some
BrowserWindows opened from new links wouldn't properly load URLs.