build: re-enable 32-bit Windows symbol generation #34162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
force-pushed
the
enable-ia32-win-symbols
branch
from
c3ab51b
to
e53c81a
Compare
jkleinsc
approved these changes
May 11, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
@VerteDinde has manually backported this PR to "19-x-y", please check out #34179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33652
This PR re-enables symbol generation on 32-bit Windows.
Note: Please don't merge unless the electron-ia32-release job is green - it went green!
Checklist
npm testpassesRelease Notes
Notes: Re-enabled symbol generation on 32-bit Windows.