fix: crash when loading extension with missing manifest #34168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
codebytere
force-pushed
the
fix-malformed-extension-crash
branch
from
f47a308
to
6f8fcc2
Compare
deepak1556
approved these changes
May 11, 2022
Co-authored-by: Robo <hop2deep@gmail.com>
MarshallOfSound
approved these changes
May 11, 2022
VerteDinde
approved these changes
May 11, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "16-x-y", please check out #34192 |
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
I was unable to backport this PR to "18-x-y" cleanly; |
|
I have automatically backported this PR to "17-x-y", please check out #34193 |
|
@codebytere has manually backported this PR to "19-x-y", please check out #34303 |
|
@codebytere has manually backported this PR to "18-x-y", please check out #34304 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: crash when loading extension missing manifest * Update electron_paks.gni Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Robo <hop2deep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34163.
Fixes a crash when calling
loadExtensionon an extension directory that's missing a manifest file. This was happening becuase the loading logic failed with a localized error string here which we didn't properly depend on. To fix this, we properly bundle the strings.Checklist
npm testpassesRelease Notes
Notes: Fixed a crash when calling
loadExtensionon an extension directory that's missing a manifest file.