fix: tray icon not highlighting on empty menu #34173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-empty-menu-highlight
branch
2 times, most recently
from
1c9aba1
to
79c114f
Compare
codebytere
force-pushed
the
fix-empty-menu-highlight
branch
from
79c114f
to
bb6d283
Compare
MarshallOfSound
approved these changes
May 11, 2022
|
Release Notes Persisted
|
This was referenced May 12, 2022
|
I have automatically backported this PR to "16-x-y", please check out #34205 |
|
I have automatically backported this PR to "17-x-y", please check out #34206 |
|
I have automatically backported this PR to "18-x-y", please check out #34207 |
|
I have automatically backported this PR to "19-x-y", please check out #34208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32111.
Ensures that the menu controller not only exists, but has a non-zero number of items before choosing to pass the click item to the superclass.
Regressed in 47a38da.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where tray items wouldn't highlight in some scenarios on macOS.