Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: re-enable 32-bit Windows symbol generation #34179

Merged
merged 1 commit into from May 11, 2022
Merged

build: re-enable 32-bit Windows symbol generation #34179

merged 1 commit into from May 11, 2022

Conversation

VerteDinde
Copy link
Member

Manual backport of #34162

See that PR for details

Note: Please don't merge unless the electron-ia32-release job is green

Notes: Re-enabled symbol generation on 32-bit Windows.

@VerteDinde VerteDinde requested a review from a team as a code owner May 11, 2022 16:44
@VerteDinde VerteDinde added backport This is a backport PR semver/patch backwards-compatible bug fixes semver/none 19-x-y and removed semver/patch backwards-compatible bug fixes labels May 11, 2022
@trop trop bot mentioned this pull request May 11, 2022
Merged
5 tasks
@VerteDinde
Copy link
Member Author

The win-ia32-testing job actually succeeded, but I think GitHub's API had a little hiccup - merging

@VerteDinde VerteDinde merged commit 082b06c into 19-x-y May 11, 2022
@VerteDinde VerteDinde deleted the enable-win32-symbols-19-x-y branch May 11, 2022 20:16
@release-clerk
Copy link

release-clerk bot commented May 11, 2022

Release Notes Persisted

Re-enabled symbol generation on 32-bit Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VerteDinde @MarshallOfSound