Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call loadUrl when opening new windows from links #34189

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 11, 2022

Backport of #34159

See that PR for details.

Notes: Fixes an issue where some BrowserWindows opened from new links wouldn't properly load URLs.

@trop trop bot requested a review from codebytere May 11, 2022 18:34
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 11, 2022
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 11, 2022
@jkleinsc jkleinsc merged commit 4ecaae9 into 19-x-y May 13, 2022
@jkleinsc jkleinsc deleted the trop/19-x-y-bp-fix-call-loadurl-when-opening-new-windows-from-links-1652294089548 branch May 13, 2022 01:49
@release-clerk
Copy link

release-clerk bot commented May 13, 2022

Release Notes Persisted

Fixes an issue where some BrowserWindows opened from new links wouldn't properly load URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants