Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when loading extension with missing manifest #34192

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 11, 2022

Backport of #34168

See that PR for details.

Notes: Fixed a crash when calling loadExtension on an extension directory that's missing a manifest file.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 11, 2022
@trop trop bot requested a review from codebytere May 11, 2022 20:41
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 11, 2022
@ckerr ckerr merged commit 8f0526f into 16-x-y May 13, 2022
@ckerr ckerr deleted the trop/16-x-y-bp-fix-crash-when-loading-extension-with-missing-manifest-1652301694153 branch May 13, 2022 16:33
@release-clerk
Copy link

release-clerk bot commented May 13, 2022

Release Notes Persisted

Fixed a crash when calling loadExtension on an extension directory that's missing a manifest file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants