New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delayed bounds when moving/resizing and preventing default #34204
Conversation
Short of a refactor that removes that special-case state field -- and it's not clear to me what we'd replace it with -- this fix looks reasonable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as a followup to my previous comment since the PR has been around for a few days now, but I'd prefer if someone else more familiar with this file also put in a review 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me, this is a small change and I think risk of regression is low 👍
Release Notes Persisted
|
I have automatically backported this PR to "16-x-y", please check out #34282 |
I have automatically backported this PR to "17-x-y", please check out #34283 |
I have automatically backported this PR to "18-x-y", please check out #34284 |
I have automatically backported this PR to "19-x-y", please check out #34285 |
Description of Change
Closes #33897.
Refs #33288.
Fixes an issue where bounds changes were incorrectly delayed in the case where a window was moved or resized and
event.preventDefault
was called in eitherwill-resize
orwill-move
. We can assume in this case that we should prevent the pending bounds if the user is overridding functionality in either callback.Tested with https://gist.github.com/ccc3e3fa4f724b5d717d9fc8f9c8dfe2 as well as https://gist.github.com/6b6ea5cdaa1883656a8bd0bf89195283 to ensure no regression of the initial issue.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where bounds changes were incorrectly delayed in the case where a window was moved or resized and
event.preventDefault
was called in eitherwill-resize
orwill-move
on Windows.